diff options
author | Lars Henriksen <LarsHenriksen@get2net.dk> | 2018-08-20 20:22:24 +0200 |
---|---|---|
committer | Lukas Fleischer <lfleischer@calcurse.org> | 2018-10-21 20:01:34 +0200 |
commit | a94b0ecde01d021795c6c29a90d60a45f9198e2d (patch) | |
tree | 6cb955bdbe1ddc7e555a9e50acdfbd081b34b582 /src/wins.c | |
parent | 37d8725e7883b02d089fd3497c1c7801130a0a58 (diff) | |
download | calcurse-a94b0ecde01d021795c6c29a90d60a45f9198e2d.tar.gz calcurse-a94b0ecde01d021795c6c29a90d60a45f9198e2d.zip |
Fix window update after hook execution
The introduction of hooks raised a problem with window updates. The diagnosis
in commit feb059e8 (Fix segmentation fault on reload with pre-load hook) was
right, the cure was wrong.
The problem is wins_update(), not the listbox contents. The wins_update() call
does not belong in wins_unprepare_external() (or in io_reload_data()), but at a
higher level. It should be called _after_ reload, as indeed it is in
key_generic_reload() when the listbox contents have been updated (todo as well
as appointments). The call was introduced in commit 8ae75f3 without comment.
The todo updates in io_reload_data() also belong in key_generic_reload() where
they were before commit 7f06c252.
When saving data, all panels must be updated in case a hook was executed.
Signed-off-by: Lars Henriksen <LarsHenriksen@get2net.dk>
Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
Diffstat (limited to 'src/wins.c')
-rw-r--r-- | src/wins.c | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -613,7 +613,6 @@ void wins_unprepare_external(void) ui_mode = UI_CURSES; wins_refresh(); wins_resize(); - wins_update(FLAG_ALL); if (notify_bar()) notify_start_main_thread(); if (conf.periodic_save > 0) |