From a94b0ecde01d021795c6c29a90d60a45f9198e2d Mon Sep 17 00:00:00 2001 From: Lars Henriksen Date: Mon, 20 Aug 2018 20:22:24 +0200 Subject: Fix window update after hook execution The introduction of hooks raised a problem with window updates. The diagnosis in commit feb059e8 (Fix segmentation fault on reload with pre-load hook) was right, the cure was wrong. The problem is wins_update(), not the listbox contents. The wins_update() call does not belong in wins_unprepare_external() (or in io_reload_data()), but at a higher level. It should be called _after_ reload, as indeed it is in key_generic_reload() when the listbox contents have been updated (todo as well as appointments). The call was introduced in commit 8ae75f3 without comment. The todo updates in io_reload_data() also belong in key_generic_reload() where they were before commit 7f06c252. When saving data, all panels must be updated in case a hook was executed. Signed-off-by: Lars Henriksen Signed-off-by: Lukas Fleischer --- src/wins.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/wins.c') diff --git a/src/wins.c b/src/wins.c index 55974be..bb08f08 100644 --- a/src/wins.c +++ b/src/wins.c @@ -613,7 +613,6 @@ void wins_unprepare_external(void) ui_mode = UI_CURSES; wins_refresh(); wins_resize(); - wins_update(FLAG_ALL); if (notify_bar()) notify_start_main_thread(); if (conf.periodic_save > 0) -- cgit v1.2.3-54-g00ecf