From a5a9ee60d62c02219ab5f2430335646beda59bc7 Mon Sep 17 00:00:00 2001 From: Lukas Fleischer Date: Tue, 5 Apr 2011 09:37:20 +0200 Subject: Fix bad use of unsigned integers. Unsigned values should never be compared to values less than zero. Detected with "find_unsigned.cocci" spatch from http://coccinelle.lip6.fr/impact_linux.php. Signed-off-by: Lukas Fleischer --- src/custom.c | 5 +++-- src/mem.c | 2 -- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/custom.c b/src/custom.c index e8cf0fe..1169b18 100644 --- a/src/custom.c +++ b/src/custom.c @@ -270,9 +270,10 @@ custom_load_conf (struct conf *conf, int background) var = 0; break; case CUSTOM_CONF_PERIODICSAVE: - conf->periodic_save = atoi (e_conf); - if (conf->periodic_save < 0) + if (atoi (e_conf) < 0) conf->periodic_save = 0; + else + conf->periodic_save = atoi (e_conf); var = 0; break; case CUSTOM_CONF_CONFIRMQUIT: diff --git a/src/mem.c b/src/mem.c index ac43103..1e54afc 100644 --- a/src/mem.c +++ b/src/mem.c @@ -95,8 +95,6 @@ stats_del_blk (unsigned id) { struct mem_blk *o, **i; - EXIT_IF (id < 0, _("Incorrect block id")); - i = &mstats.blk; for (o = mstats.blk; o; o = o->next) { -- cgit v1.2.3-54-g00ecf