path: root/src/help.c
diff options
authorLukas Fleischer <calcurse@cryptocrack.de>2012-12-16 00:16:13 +0100
committerLukas Fleischer <calcurse@cryptocrack.de>2012-12-16 02:27:36 +0100
commite492ac6f952043c3b4adbfffb3711be638a93883 (patch)
tree4b414ef1fccdc5c1364e88d2832315ba11c76e8a /src/help.c
parentaa7844942e1d5e33894c236d326abfbb30462c8f (diff)
Add hidden key handler window
After BUG#6 had apparently been closed with the screen locks introduced in commit a80f8dcf2c6eb3b54658218bc081ee9694204dd5, some people still had problems with random characters appearing in the notification bar. This was obviously caused by wgetch() refreshing the screen if the status panel was changed. From wgetch(3): If the window is not a pad, and it has been moved or modified since the last call to wrefresh, wrefresh will be called before another character is read. Since the wgetch(3) isn't thread-safe, there were race conditions between the notification bar thread drawing to the notification bar and wgetch() updating the screen. Introduce a (hidden) window that handles all key presses and never gets changed in order to avoid this. Also, call wins_wrefresh() explicitly in status_mesg(), since we can no longer rely on wgetch() updating windows automatically. Fixes reopened BUG#6. Note that this is a hotfix -- FR#26 has been opened to ensure we fix this properly in the next major release. Signed-off-by: Lukas Fleischer <calcurse@cryptocrack.de>
Diffstat (limited to 'src/help.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/help.c b/src/help.c
index a8d3edb..d9afd4c 100644
--- a/src/help.c
+++ b/src/help.c
@@ -793,7 +793,7 @@ void help_screen(void)
- ch = keys_getch(win[STA].p, NULL, NULL);
+ ch = keys_getch(win[KEY].p, NULL, NULL);
if (need_resize)