aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Fleischer <lfleischer@calcurse.org>2020-11-07 19:35:43 -0500
committerLukas Fleischer <lfleischer@calcurse.org>2020-11-07 19:53:21 -0500
commite1b5580bdf323959b08054cceec01174b9d33ded (patch)
treebd6ba5a7bff2c583a28ebff59b8acb1650a53991
parent97df01b534ac5616f39c1a1ffff8fc8e3e7927f9 (diff)
downloadcalcurse-e1b5580bdf323959b08054cceec01174b9d33ded.tar.gz
calcurse-e1b5580bdf323959b08054cceec01174b9d33ded.zip
Avoid double free on iCal import errors
Set pointers to NULL after calling free() to prevent double free on cleanup. Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
-rw-r--r--src/ical.c15
1 files changed, 13 insertions, 2 deletions
diff --git a/src/ical.c b/src/ical.c
index d62bb59..2ce378c 100644
--- a/src/ical.c
+++ b/src/ical.c
@@ -1398,8 +1398,10 @@ ical_read_event(FILE * fdi, FILE * log, unsigned *noevents,
goto skip;
}
vevent.start = ical_datetime2time_t(p, tzid, vevent_type);
- if (tzid)
+ if (tzid) {
mem_free(tzid);
+ tzid = NULL;
+ }
if (!vevent.start) {
ical_log(log, ICAL_VEVENT, ITEMLINE,
_("invalid or malformed event "
@@ -1422,8 +1424,10 @@ ical_read_event(FILE * fdi, FILE * log, unsigned *noevents,
goto skip;
}
vevent.end = ical_datetime2time_t(p, tzid, vevent_type);
- if (tzid)
+ if (tzid) {
mem_free(tzid);
+ tzid = NULL;
+ }
if (!vevent.end) {
ical_log(log, ICAL_VEVENT, ITEMLINE,
_("malformed event end time."));
@@ -1506,6 +1510,7 @@ ical_read_event(FILE * fdi, FILE * log, unsigned *noevents,
if (vevent.desc) {
string_catf(&s, "%s", vevent.desc);
mem_free(vevent.desc);
+ vevent.desc = NULL;
}
if (separator)
string_catf(&s, SEPARATOR);
@@ -1513,16 +1518,19 @@ ical_read_event(FILE * fdi, FILE * log, unsigned *noevents,
string_catf(&s, _("Location: %s"),
vevent.loc);
mem_free(vevent.loc);
+ vevent.loc = NULL;
}
if (vevent.comm) {
string_catf(&s, _("Comment: %s"),
vevent.comm);
mem_free(vevent.comm);
+ vevent.comm = NULL;
}
if (vevent.imp) {
string_catf(&s, ("Import: %s\n"),
vevent.imp);
mem_free(vevent.imp);
+ vevent.imp = NULL;
}
vevent.note = generate_note(string_buf(&s));
mem_free(s.buf);
@@ -1734,6 +1742,7 @@ ical_read_todo(FILE * fdi, FILE * log, unsigned *notodos, unsigned *noskipped,
if (vtodo.desc) {
string_catf(&s, "%s", vtodo.desc);
mem_free(vtodo.desc);
+ vtodo.desc = NULL;
}
if (separator)
string_catf(&s, SEPARATOR);
@@ -1741,11 +1750,13 @@ ical_read_todo(FILE * fdi, FILE * log, unsigned *notodos, unsigned *noskipped,
string_catf(&s, _("Location: %s"),
vtodo.loc);
mem_free(vtodo.loc);
+ vtodo.loc = NULL;
}
if (vtodo.comm) {
string_catf(&s, _("Comment: %s"),
vtodo.comm);
mem_free(vtodo.comm);
+ vtodo.comm = NULL;
}
vtodo.note = generate_note(string_buf(&s));
mem_free(s.buf);